Fix terminal launch blocking srepd until window closed#238
Merged
Conversation
Replace blocking stdout/stderr pipes and cmd.Wait() with cmd.Start() and background goroutine for process reaping. srepd returns to normal immediately after terminal opens. Closes #237 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 67.73% 68.63% +0.90%
==========================================
Files 26 26
Lines 3790 3740 -50
==========================================
Hits 2567 2567
+ Misses 1088 1038 -50
Partials 135 135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace blocking stdout/stderr pipes + cmd.Wait() with cmd.Start() + background goroutine for zombie reaping. srepd returns to normal immediately after the terminal opens.
Confirmed working with ptyxis — no longer freezes.
Closes #237
🤖 Generated with Claude Code