Add macOS log viewer support with OS-aware log path selection#239
Merged
Conversation
Set logFilePath based on runtime.GOOS so the log viewer pane reads from the correct platform-specific location: ~/Library/Logs/srepd.log on macOS and ~/.config/srepd/debug.log on Linux. Also fixes InitialModelWithConfig missing logViewer and logFilePath initialization. Closes #196 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 67.73% 68.74% +1.01%
==========================================
Files 26 26
Lines 3790 3750 -40
==========================================
+ Hits 2567 2578 +11
+ Misses 1088 1036 -52
- Partials 135 136 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logFilePathForOS()selects log path by OS: Linux~/.config/srepd/debug.log, macOS~/Library/Logs/srepd.logInitialModelWithConfigmissinglogViewer/logFilePathinitCloses #196
🤖 Generated with Claude Code