Repository navigation
[pre-commit.ci] pre-commit autoupdate - #56
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR is an automated pre-commit.ci dependency update that advances the pinned Pyrefly and rumdl hook revisions in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".pre-commit-config.yaml" line_range="55" />
<code_context>
exclude: ^\.specify/scripts/
- repo: https://github.com/facebook/pyrefly-pre-commit
- rev: 1.3.1
+ rev: 1.4.0.dev1
hooks:
- id: pyrefly-check
</code_context>
<issue_to_address>
**issue (broader_impact):** The bundled preset copies remain pinned to the old revisions (`lang/py/preset.yaml` still uses pyrefly 1.3.1 and `lang/md/preset.yaml` still uses rumdl v0.2.73), so the repository's preset-validation workflow rewrites those files during `prek autoupdate` and `git diff --exit-code` fails. Generated configurations therefore also continue to use the outdated hooks despite this update.
**Triggers:** When the `validate-presets` workflow runs on a pull request targeting `main`, a tag, or the `main` branch.
**Suggested fix:** Update the corresponding revisions in `lang/py/preset.yaml` and `lang/md/preset.yaml` to 1.4.0.dev1 and v0.2.75.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .pre-commit-config.yaml:55
| exclude: ^\.specify/scripts/ | ||
| - repo: https://github.com/facebook/pyrefly-pre-commit | ||
| rev: 1.3.1 | ||
| rev: 1.4.0.dev1 |
There was a problem hiding this comment.
issue (broader_impact): The bundled preset copies remain pinned to the old revisions (lang/py/preset.yaml still uses pyrefly 1.3.1 and lang/md/preset.yaml still uses rumdl v0.2.73), so the repository's preset-validation workflow rewrites those files during prek autoupdate and git diff --exit-code fails. Generated configurations therefore also continue to use the outdated hooks despite this update.
Triggers: When the validate-presets workflow runs on a pull request targeting main, a tag, or the main branch.
Suggested fix: Update the corresponding revisions in lang/py/preset.yaml and lang/md/preset.yaml to 1.4.0.dev1 and v0.2.75.
There was a problem hiding this comment.
LlamaPReview — Conditional code-review clear
The change advances exactly the two pre-commit hook pins named in the PR body, and pre-commit.ci's successful run shows both new revisions resolve and execute cleanly, so the update is safe to merge.
Exact-head CI remains unresolved (6 pending); no CI-dependent merge-safety claim is made.
1 non-blocking finding retained — highest: Pyrefly hook now tracks a development build instead of a stable release.
Review details and evidence
| Priority | File | Finding | Evidence |
|---|---|---|---|
| P2 | .pre-commit-config.yaml |
Pyrefly hook now tracks a development build instead of a stable release. | confirmed |
Material unknowns
- The upstream content of the tags
1.4.0.dev1(pyrefly) andv0.2.75(rumdl) — their changelogs and release diffs are not in the supplied evidence. Exact knowledge of what changed inside those releases would refine the severity of the pyrefly stable-vs-dev note; it does not decide the merge posture, which rests on the pins being updated and the pinned hooks running successfully at head.- Check: If the specific changes matter, review the upstream release notes for the two tags; otherwise no action is needed for merge.
LlamaPReview checks
- Reviewed changed regions in
.pre-commit-config.yaml. - Read the complete PR-head file
.pre-commit-config.yaml.
LlamaPReview is an open-source pull request reviewer. Tell the maintainers where this review got it wrong.
| exclude: ^\.specify/scripts/ | ||
| - repo: https://github.com/facebook/pyrefly-pre-commit | ||
| rev: 1.3.1 | ||
| rev: 1.4.0.dev1 |
There was a problem hiding this comment.
P2 | Confidence: High
The pyrefly repo rev moved from the stable 1.3.1 to the development tag 1.4.0.dev1, which is the tag now fetched and installed by every developer and CI run that executes the pyrefly-check hook. Any invocation of that hook installs the dev build, and dev builds can carry unreleased checker behavior changes, so failure output or newly surfaced diagnostics could differ from the stable line on an unrelated future change. This is a stability consideration rather than an observed defect: the pre-commit.ci - pr run at the current head succeeded, meaning the dev build resolved and ran cleanly against this repository with the configured additional_dependencies (pytest, pyyaml, ruamel.yaml, typer), and no behavioral regression is evidenced. The bump is confined to this one rev: line; the hook id, its additional_dependencies, and every other hook revision are unchanged.
Owner action: No change required for merge. If the project prefers to track only stable checker releases, hold this block at a stable tag; otherwise the next autoupdate cycle will move it again.
Evidence: changed region in .pre-commit-config.yaml; PR-head read of .pre-commit-config.yaml.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #56 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 23 23
Lines 3301 3301
========================================
Hits 3291 3291
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
710dbdc to
b750c55
Compare
updates: - [github.com/astral-sh/ruff-pre-commit: v0.16.8 → v0.16.10](astral-sh/ruff-pre-commit@v0.16.8...v0.16.10) - [github.com/crate-ci/typos: v1.50.2 → typos-dict-v0.14.2](crate-ci/typos@v1.50.2...typos-dict-v0.14.2) - [github.com/facebook/pyrefly-pre-commit: 1.3.1 → 1.3.2](meta/pyrefly-pre-commit@1.3.1...1.3.2) - [github.com/rvben/rumdl-pre-commit: v0.2.73 → v0.2.78](rvben/rumdl-pre-commit@v0.2.73...v0.2.78) - [github.com/astral-sh/ty-pre-commit: v0.0.82 → v0.0.84](astral-sh/ty-pre-commit@v0.0.82...v0.0.84) - [github.com/owenlamont/ryl-pre-commit: v0.22.0 → v0.24.0](owenlamont/ryl-pre-commit@v0.22.0...v0.24.0)
b750c55 to
81545f1
Compare
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: Customizable Safeguards
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
updates:
Summary by Sourcery
Enhancements: