Sort vendor analytics by share#41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original request
Use
pr-workflowto sort vendors on the Vendors page by descending share, matching how the Dashboard page presents share-based rows.What changed
Reasoning
The Vendors page already computes and displays each vendor's share relative to the relevant income or expense total. Sorting in
VendorGroupkeeps the change scoped to the page behavior requested, preserves the existing grouped layout, and avoids changing the broader dashboard API contract ortopVendorssemantics for other callers.Screenshots / preview evidence
/tmp/xpenser-pr-041-vendors-month.png. The current GitHub connector does not expose binary attachment upload.Validation
npm test -- apps/web/components/vendor-analytics-panel.test.tsxpassed locally.npm run lintpassed locally.npm run typecheckpassed locally.npm testpassed locally: 65 files, 356 tests.Lint and testpassed.Deploy PR environmentpassed.Playwright e2epassed.https://xpenser-pr-041.cleverbrush.com/vendors?period=month&date=2026-06-01.xpenser-web-pr-41traces present for preview activity, no error traces returned; recentxpenser-api-pr-41error traces returned no rows.xpenser-web-pr-41andxpenser-api-pr-41returned no rows.xpenser-api-pr-41http.server.duration.countreported 107 requests in the queried window.xpenser-web-pr-41did not expose metricservice.namevalues in SigNoz during the checked window; web traces/logs were present and clean.