Skip to content

Lodash support 3+ #88#89

Open
mikeapr4 wants to merge 1 commit into
cloudchen:masterfrom
mikeapr4:Lodash-3+-support
Open

Lodash support 3+ #88#89
mikeapr4 wants to merge 1 commit into
cloudchen:masterfrom
mikeapr4:Lodash-3+-support

Conversation

@mikeapr4

Copy link
Copy Markdown

Note: this is backwards compatible to pre-v3 versions also.

@radum

radum commented May 17, 2016

Copy link
Copy Markdown

Hey @mikeapr4

Might be better if we upgrade this to Grunt 1.0 also. Here is a PR that should handle all of it #90

@mikeapr4

Copy link
Copy Markdown
Author

Hi @radum , I see your PR and it makes sense to replace usage of grunt.util._ as it's deprecated anyway. I chose the least amount of change, but your PR looks good to me. However your dev Grunt dependency upgrade has triggered some NPM warnings which has caused the build to go red.

@radum

radum commented May 24, 2016

Copy link
Copy Markdown

Hi @mikepr4,. Yeah just saw them. Once I get back from holiday next week I will fix those also. And we can move it fwd.

Thanks a lot

@wpwood wpwood mentioned this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants