Merge pull request #26 from cloudengine-labs/copilot/review-bug-1-pull-request

fix(gitlab-ci): BUG-1 — empty stages and no deploy job when `--type deploy` without `--kubernetes`

Author: chefgs

cli/scaffold_gitlab.py

@@ -225,9 +225,22 @@ def _test_job(lang_config):
 
 
 def _deploy_job(args):
-    """Kubernetes deploy job."""
+    """Kubernetes deploy job, or a generic deploy stub when kubernetes is disabled."""
     if not args.kubernetes:
-        return {}
+        protected_branches = [b.strip() for b in args.branches.split(",")]
+        rules = [
+            {"if": f"$CI_COMMIT_BRANCH == \"{b}\"", "when": "manual" if b != protected_branches[0] else "on_success"}
+            for b in protected_branches
+        ]
+        return {
+            "deploy": {
+                "stage": "deploy",
+                "script": [
+                    "echo \"Deploy stage — configure your deployment scripts here\"",
+                ],
+                "rules": rules,
+            }
+        }
 
     protected_branches = [b.strip() for b in args.branches.split(",")]
 
@@ -298,7 +311,7 @@ def generate_pipeline(args, custom_values):
     if args.type in ("test", "complete"):
         pipeline.update(_test_job(lang_config))
 
-    if args.type in ("deploy", "complete") and args.kubernetes:
+    if args.type == "deploy" or (args.type == "complete" and args.kubernetes):
         pipeline.update(_deploy_job(args))
 
     pipeline.update(custom_values)

tests/test_comprehensive.py

@@ -619,7 +619,8 @@ def test_deploy_pipeline_no_kubernetes_empty_stages(self):
         """
         BUG-1: When type='deploy' and kubernetes=False, the generated
         pipeline has an empty stages list, which is invalid for GitLab CI.
-        Expected: at least one stage should be present even for non-k8s deploy.
+        Expected: at least one stage should be present even for non-k8s deploy,
+        and a deploy job stub must be present in the pipeline.
         """
         with tempfile.TemporaryDirectory() as tmp:
             out = os.path.join(tmp, ".gitlab-ci.yml")
@@ -636,6 +637,10 @@ def test_deploy_pipeline_no_kubernetes_empty_stages(self):
             assert len(stages) > 0, (
                 "Expected at least one stage in a deploy pipeline, got: {!r}".format(stages)
             )
+            # A deploy job stub must be present so the pipeline is valid
+            assert "deploy" in data, (
+                "Expected a deploy job in the pipeline, got keys: {!r}".format(list(data.keys()))
+            )
 
 
 # ===========================================================================