ci(semgrep): pin contents: read on the daily scan#43
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
The Semgrep scheduled scan only checks out the repo and runs `semgrep ci` inside the official semgrep container, so the default GITHUB_TOKEN doesn't need any write scopes. This is the only workflow in this repo and the top-level permissions style matches other cloudflare/* repos (e.g. cloudflare/cloudflare-docs). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
c71e2bc to
1aec033
Compare
Author
|
Hi @SirCortly, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-approver side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENto read-only forsemgrep.yml, the only workflow in this repo. The workflow runs nightly inside the officialsemgrep/semgrepcontainer and only needs read access to the checkout — semgrep findings are pushed back to Cloudflare's own Semgrep AppSec viaSEMGREP_APP_TOKEN, not via the GitHub token.Matches the top-level
permissions: contents: readstyle already used by other cloudflare repos (e.g.cloudflare/cloudflare-docs,cloudflare/pint). YAML validated withyaml.safe_load.