Switch build tool from tsup to tsdown#50
Conversation
|
@threepointone What is the best practice here in your opinion? |
|
tsup's fine in that it's not broken, but I'll investigate tsdown (and use it in a couple of repos too if it's straightforward). but for now it's fine, even agents uses tsup atm. |
|
oh this is a PR. lemme verify and come back it. |
|
I tested tsdown, it's pretty good, faster. We moved agents to it. We could land this one. |
|
Update: We'd like to land this but @threepointone mentioned something about a dependency version conflict with vitest-pool-workers? Maybe he can explain. |
|
Hey @kingsword09, thanks for sending this PR. We’d like to get this merged, but the CLA check is currently blocking it. Could you please sign the Contributor License Agreement by commenting the following on this PR? |
I have read the CLA Document and I hereby sign the CLA |
afc44f3 to
cfc7a83
Compare
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Thanks @kingsword09. I rebased the PR onto latest main, resolved the conflicts, and fixed the Workers build/test issue. The CLA bot is still failing, possibly because your previous CLA comment included quoted text. Could you please add a new comment containing only this exact line, with no quote or extra text? |
|
I have read the CLA Document and I hereby sign the CLA |
tsup is not actively maintained anymore. Official documentation also recommends migration to tsdown.