Skip to content

Switch build tool from tsup to tsdown#50

Merged
teamchong merged 1 commit into
cloudflare:mainfrom
kingsword09:switch-tsup-to-tsdown
May 20, 2026
Merged

Switch build tool from tsup to tsdown#50
teamchong merged 1 commit into
cloudflare:mainfrom
kingsword09:switch-tsup-to-tsdown

Conversation

@kingsword09
Copy link
Copy Markdown
Contributor

tsup is not actively maintained anymore. Official documentation also recommends migration to tsdown.

@kentonv
Copy link
Copy Markdown
Member

kentonv commented Sep 25, 2025

@threepointone What is the best practice here in your opinion?

@threepointone
Copy link
Copy Markdown
Collaborator

tsup's fine in that it's not broken, but I'll investigate tsdown (and use it in a couple of repos too if it's straightforward). but for now it's fine, even agents uses tsup atm.

@threepointone
Copy link
Copy Markdown
Collaborator

oh this is a PR. lemme verify and come back it.

@threepointone
Copy link
Copy Markdown
Collaborator

I tested tsdown, it's pretty good, faster. We moved agents to it. We could land this one.

@kentonv
Copy link
Copy Markdown
Member

kentonv commented Nov 5, 2025

Update: We'd like to land this but @threepointone mentioned something about a dependency version conflict with vitest-pool-workers? Maybe he can explain.

@teamchong
Copy link
Copy Markdown
Collaborator

Hey @kingsword09, thanks for sending this PR. We’d like to get this merged, but the CLA check is currently blocking it. Could you please sign the Contributor License Agreement by commenting the following on this PR?

I have read the CLA Document and I hereby sign the CLA

@kingsword09
Copy link
Copy Markdown
Contributor Author

Hey @kingsword09, thanks for sending this PR. We’d like to get this merged, but the CLA check is currently blocking it. Could you please sign the Contributor License Agreement by commenting the following on this PR?

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

@teamchong teamchong force-pushed the switch-tsup-to-tsdown branch from afc44f3 to cfc7a83 Compare May 20, 2026 13:49
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

⚠️ No Changeset found

Latest commit: cfc7a83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamchong
Copy link
Copy Markdown
Collaborator

I have read the CLA Document and I hereby sign the CLA

@teamchong
Copy link
Copy Markdown
Collaborator

recheck

@teamchong
Copy link
Copy Markdown
Collaborator

Thanks @kingsword09. I rebased the PR onto latest main, resolved the conflicts, and fixed the Workers build/test issue.
The branch is updated and ready for review/merge.

The CLA bot is still failing, possibly because your previous CLA comment included quoted text. Could you please add a new comment containing only this exact line, with no quote or extra text?

I have read the CLA Document and I hereby sign the CLA

@kingsword09
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 20, 2026
@dimitropoulos dimitropoulos self-requested a review May 20, 2026 15:04
@teamchong teamchong merged commit 5eb7701 into cloudflare:main May 20, 2026
3 of 5 checks passed
@kingsword09 kingsword09 deleted the switch-tsup-to-tsdown branch May 20, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants