Skip to content

feat: landing page redesign#29453

Open
MohamedH1998 wants to merge 39 commits into
productionfrom
feat/landing-page-redesign
Open

feat: landing page redesign#29453
MohamedH1998 wants to merge 39 commits into
productionfrom
feat/landing-page-redesign

Conversation

@MohamedH1998
Copy link
Copy Markdown
Contributor

Summary

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.ts @cloudflare/content-engineering, @kodster28
* @cloudflare/product-owners
*.astro @cloudflare/content-engineering, @kodster28

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

@MohamedH1998
Copy link
Copy Markdown
Contributor Author

/bonk please review

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 1, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 1, 2026

@MohamedH1998 Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@MohamedH1998
Copy link
Copy Markdown
Contributor Author

/bonk please review

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 1, 2026

UnknownError: ProviderInitError

github run

@github-actions
Copy link
Copy Markdown
Contributor

Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant).

@MohamedH1998 MohamedH1998 force-pushed the feat/landing-page-redesign branch from bd498f3 to 8bf4c56 Compare May 5, 2026 12:33
@MohamedH1998 MohamedH1998 marked this pull request as ready for review May 5, 2026 16:59
@MohamedH1998 MohamedH1998 requested review from a team and kodster28 as code owners May 5, 2026 16:59
@MohamedH1998 MohamedH1998 requested a review from a team May 5, 2026 16:59
@MohamedH1998 MohamedH1998 changed the title WIP feat: landing page redesign May 5, 2026
@MohamedH1998 MohamedH1998 requested a review from a team as a code owner May 19, 2026 10:49
@MohamedH1998
Copy link
Copy Markdown
Contributor Author

/bonk review

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 19, 2026

@MohamedH1998 Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 3 issues and posted 3 suggestions.

Fixed directly:

  • : Restored — the commented-out negation would have caused the directory to be ignored.
  • : Removed the MCP server block containing a hardcoded local developer path ().
  • : Removed the trailing period from the section heading per the style guide (headings must not end with punctuation).

Posted inline suggestions for:

  • Import path consistency ( alias).
  • API example placeholder format ( instead of ).
  • Removal of dead code comment.

Comment thread src/pages/index.astro Outdated
Comment thread src/components/landing/BuildFromScratch.astro Outdated
Comment thread src/components/landing/AccelerateSection.astro Outdated
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 19, 2026

Follow-up on the review above:

I fixed 3 issues directly and attempted to post 3 inline suggestions (the original review body was mangled by shell escaping). Here are the suggestions again:

  1. src/pages/index.astro (lines 4-13): Change ../components/landing/ imports to ~/components/landing/ for consistency with the rest of the codebase.

  2. src/components/landing/BuildFromScratch.astro (line 83): Change {account_id} to $ACCOUNT_ID in the curl example. The style guide requires shell variable format for API examples.

  3. src/components/landing/AccelerateSection.astro (lines 32-33): Remove the dead code comment <!-- Leave out till approval --> and the commented-out <Waterfall> component. If Waterfall is not shipping, consider removing its file and the unused phases/phaseColor imports as well.

What I already fixed:

  • .gitignore: Restored !.agents/skills/ — without this negation, the .agents/skills/ directory would be ignored by the skills/ pattern above it.
  • opencode.jsonc: Removed the MCP server block containing a hardcoded local path (/Users/mhassan/Documents/dev/tinkering/aperture/build/index.js). This should not be committed.
  • src/components/landing/SecureSection.astro: Removed the trailing period from the heading "Block exploits, bots, and DDoS attacks in seconds" per the style guide (headings must not end with punctuation).

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 inline suggestions for import consistency, API placeholder format, and dead code removal.

Comment thread src/pages/index.astro Outdated
Comment thread src/components/landing/BuildFromScratch.astro Outdated
Comment thread src/components/landing/AccelerateSection.astro Outdated
Co-authored-by: MohamedH1998 <MohamedH1998@users.noreply.github.com>
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 19, 2026

Review complete for PR #29453.

Fixed 3 issues directly:

  • .gitignore — Restored !.agents/skills/. The commented-out negation would have caused the .agents/skills/ directory to be ignored by the skills/ pattern above it.
  • opencode.jsonc — Removed the MCP server block containing a hardcoded local developer path (/Users/mhassan/Documents/dev/tinkering/aperture/build/index.js). This should not be committed to the repo.
  • src/components/landing/SecureSection.astro — Removed the trailing period from the heading "Block exploits, bots, and DDoS attacks in seconds" per the style guide (headings must not end with punctuation).

Posted 3 inline suggestions:

  • src/pages/index.astro — Change ../components/landing/ imports to ~/components/landing/ for consistency with the rest of the codebase.
  • src/components/landing/BuildFromScratch.astro — Change {account_id} to $ACCOUNT_ID in the curl example per the style guide for API shell variables.
  • src/components/landing/AccelerateSection.astro — Remove the dead code comment <!-- Leave out till approval --> and the commented-out <Waterfall> component. If Waterfall is not shipping, consider removing its file and the unused phases / phaseColor imports as well.

No build-breaking MDX syntax issues or invalid frontmatter were found. The new landing components are well-structured with good accessibility attributes (aria-labelledby, role, keyboard navigation, and prefers-reduced-motion fallbacks).

github run

MohamedH1998 and others added 5 commits May 19, 2026 12:35
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants