Fixed Workers duration limits in 6 files.#30871
Open
ask-bonk[bot] wants to merge 6 commits into
Open
Conversation
Co-authored-by: irvinebroque <irvinebroque@users.noreply.github.com>
ask-bonk
Bot
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne,
mikenomitch and
nevikashah
as code owners
Contributor
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
github-actions
Bot
assigned
GregBrimble,
irvinebroque,
korinne,
MattieTK,
mikenomitch,
WalshyDev and
nevikashah
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
irvinebroque
requested review from
Oxyjun,
elithrar,
joshthoward,
lambrospetrou and
vy-ton
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done! I've addressed the issue across six files. Here's what changed:
1. HTTP request duration limits (the core issue)
Files:
src/content/docs/workers/platform/limits.mdx,src/content/partials/workers/wall-time-limits.mdxwaitUntil()description: it no longer says it "delays cancellation for another 30 seconds after the response is sent." Instead, it states thatwaitUntil()tasks must complete within the same 30-second total wall time.2.
ctx.waitUntil()duration wordingFile:
src/content/docs/workers/runtime-apis/context.mdxwaitUntil()tasks must finish within that total limit (not 30 seconds after the response).3. Best practices guidance
File:
src/content/docs/workers/best-practices/workers-best-practices.mdxwaitUntiltime limit after the response is sent" to "exceeding the 30-second total invocation wall time limit."4. Scheduled handlers and
waitUntilnecessityFile:
src/content/docs/workers/runtime-apis/handlers/scheduled.mdxawait doSomeTaskOnASchedule()instead ofctx.waitUntil(doSomeTaskOnASchedule()), reflecting that the runtime waits for the returned promise.ctx.waitUntil()method description to say it registers tasks rather than "notifies the runtime to wait.":::noteexplaining that the runtime waits for the handler's returned promise (up to 15 minutes), sowaitUntil()is not required for single async tasks, but remains useful for concurrent tasks and Cron Trigger status reporting.5. Errors/logging page wording
File:
src/content/docs/workers/observability/errors.mdxctx.waitUntil()ensures completion.ctx.waitUntil()docs instead of the generic MDNevent.waitUntil()page.Validation
pnpm run checkpassed with 0 errors.Closes #30529
github run