[Chore] Simplify logic around tags#30892
Open
kodster28 wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
product:workers
github-actions
Bot
assigned
aninibread,
GregBrimble,
MattieTK,
elithrar,
irvinebroque,
korinne,
mikenomitch and
WalshyDev
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
ask-bonk
Bot
added
engineering
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues need fixing before merge.
CRITICAL
src/content/docs/style-guide/frontmatter/tags.mdximports and renders<TagsUsage />, which was deleted in this PR. This will break the build. The page also references the deleted/src/schemas/tags.ts. This page should be rewritten or removed.
HIGH
src/content/docs/style-guide/components/resources-by-selector.mdxwas updated to change thefilterablesexample, but lines 12 and 34–44 still document the deletedtagsprop andfilterables={["tags"]}. Clean up the rest of this page.src/content/docs/style-guide/components/external-resources.mdxlinks to/style-guide/frontmatter/tags/for a canonical tag list, but that page's allowlist visualization was removed. Remove or update this link.
MEDIUM
src/content/docs/style-guide/components/index.mdxdescribesResourcesBySelectoras filtering "based on tags and content type" — update to "content type and products".
| directory="workers/examples/" | ||
| types={["example"]} | ||
| filterables={["tags"]} | ||
| filterables={["products"]} |
Contributor
There was a problem hiding this comment.
This example was updated, but the rest of this file still references the deleted tags prop and filterables={["tags"]} (lines 12 and 34–44). Please clean those up too.
Contributor
|
I’ve completed the review of PR #30892 and posted a review comment with inline feedback. Summary of changesThis PR removes the tag allowlist and enforcement infrastructure from the docs site:
Labels applied
Issues flaggedCRITICAL
HIGH
MEDIUM
I posted these findings as a PR review (with an inline comment on the one changed line I could target directly; the remaining issues are in unchanged files that are now stale due to the deletions in this PR). |
Contributor
|
This PR requires additional review attention because it affects the following areas: RedirectsThis PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
Collaborator
Author
|
/bonk re-review based on the latest changes |
kodster28
requested review from
a team,
GregBrimble,
MattieTK and
aninibread
as code owners
kodster28
requested review from
a team,
WalshyDev,
elithrar,
irvinebroque,
korinne and
mikenomitch
as code owners
Co-authored-by: kodster28 <kodster28@users.noreply.github.com>
Contributor
|
Fixed 4 remaining stale references to the deleted tag filtering functionality:
The previously flagged CRITICAL and HIGH issues ( |
Contributor
kodster28
commented
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up some of the unused, overly heavyweight logic we have running behind the scenes of our docs site.