[Chore] Remove outdated files#30895
Conversation
kodster28
requested review from
a team,
GregBrimble,
MattieTK,
Oxyjun,
WalshyDev,
aninibread,
elithrar,
harshil1712,
irvinebroque,
jonesphillip,
joshthoward,
korinne,
lambrospetrou,
migueldemoura,
mikenomitch,
punkeel,
ravindra-cloudflare,
renandincer,
roerohan,
rozenmd,
sejoker,
thomasgauvin and
vy-ton
as code owners
github-actions
Bot
added
product:email-routing
product:durable-objects
|
This PR requires additional review attention because it affects the following areas: RedirectsThis PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
github-actions
Bot
assigned
elithrar,
harshil1712,
joshthoward,
Oxyjun,
rozenmd,
vy-ton,
lambrospetrou,
mikenomitch,
sejoker and
thomasgauvin
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues need attention before merge.
HIGH: Missing redirect for deleted style guide page /style-guide/components/external-resources/. Add:
MEDIUM: deploy-a-nuxt-site.mdx appears to have accidentally removed the internal ResourcesBySelector tutorials section along with the external demos section.
LOW: PR title typo — "oudated" should be "outdated".
| /email-routing/enable-email-routing/ /email-routing/get-started/enable-email-routing/ 301 | ||
| /email-routing/get-started/email-addresses/ /email-routing/setup/email-routing-addresses/ 301 | ||
| /email-routing/known-limitations/ /email-routing/postmaster/ 301 | ||
| /email-routing/email-workers/demos/ /email-routing/email-workers/ 301 |
There was a problem hiding this comment.
Add a redirect for the deleted /style-guide/components/external-resources/ page as well (target /style-guide/components/index/).
| @@ -174,17 +173,3 @@ export default defineEventHandler(({ context }) => { | |||
| product="pages" | |||
| params={{ one: "Nuxt" }} | |||
| /> | |||
There was a problem hiding this comment.
Restore the tutorials section (the ResourcesBySelector component is unrelated to the removed ExternalResources logic):
| /> | |
| /> | |
| ## Related resources | |
| ### Tutorials | |
| For more tutorials involving Nuxt, refer to the following resources: | |
| <ResourcesBySelector tags={["Nuxt"]} types={["tutorial"]} /> |
| /email-routing/enable-email-routing/ /email-routing/get-started/enable-email-routing/ 301 | ||
| /email-routing/get-started/email-addresses/ /email-routing/setup/email-routing-addresses/ 301 | ||
| /email-routing/known-limitations/ /email-routing/postmaster/ 301 | ||
| /email-routing/email-workers/demos/ /email-routing/email-workers/ 301 |
There was a problem hiding this comment.
Add a redirect for the deleted /style-guide/components/external-resources/ page as well (target /style-guide/components/index/).
| @@ -174,17 +173,3 @@ export default defineEventHandler(({ context }) => { | |||
| product="pages" | |||
| params={{ one: "Nuxt" }} | |||
| /> | |||
There was a problem hiding this comment.
Restore the tutorials section (the ResourcesBySelector component is unrelated to the removed ExternalResources logic):
| /> | |
| /> | |
| ## Related resources | |
| ### Tutorials | |
| For more tutorials involving Nuxt, refer to the following resources: | |
| <ResourcesBySelector tags={["Nuxt"]} types={["tutorial"]} /> |
ask-bonk
Bot
added
documentation
|
Review posted on PR #30895. Labels applied: Summary of changes: Issues flagged:
Posted 2 inline review comments with the above details. |
11 participants
Remove some outdated files (and the logic that let us surface them)