[Logs] Update Logpush dataset field definitions (2026-05-19)#30910
[Logs] Update Logpush dataset field definitions (2026-05-19)#30910soheiokamoto wants to merge 1 commit into
Conversation
|
/bonk please review this automated sync of Logpush dataset field definitions. Focus on the following:
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues need attention before merge.
MEDIUM — src/content/docs/logs/logpush/logpush-job/datasets/zone/http_requests.md line 460: The abbreviation FL in the MatchedRules description is undefined. Per the style guide, acronyms must be spelled out on first use. Please update the internal source YAML.
MEDIUM — src/content/docs/logs/logpush/logpush-job/datasets/zone/http_requests.md line 484: "Read more [here]" violates the style guide rule against non-descriptive link text. Suggestion provided inline.
LOW — The PR body and changelog list only two added fields, but the diff also includes description updates in mnm_flow_logs.md, firewall_events.md, and http_requests.md. Consider expanding the summary so reviewers know the full scope.
|
|
||
| Type: `array[object]` | ||
|
|
||
| Array of matched FL product rules grouped by product. Each object contains: <em>product</em> (string, e.g. snippets, transform, redirects), <em>rulesetId</em> (string), <em>rulesetVersion</em> (int), and <em>rules</em> (array of objects, each with <em>id</em> (string) and optional <em>metadata</em> (object with string key-value pairs)). |
There was a problem hiding this comment.
Undefined acronym. The style guide requires spelling out abbreviations on first use. Please update the internal source YAML to clarify what FL means, or remove the abbreviation.
| Type: `int` | ||
|
|
||
| Number of bytes returned by the origin server. | ||
| Number of bytes returned by the origin server. Consider using CacheResponseBytes and filtering out OriginResponseStatus with values 0 and 304, which indicate a revalidated response. Read more [here](/logs/faq/common-calculations/#how-can-i-calculate-bytes-served-by-the-origin-from-cloudflare-logs). |
There was a problem hiding this comment.
Fix link text per style guide (never use "here", "read more", etc.):
| Number of bytes returned by the origin server. Consider using CacheResponseBytes and filtering out OriginResponseStatus with values 0 and 304, which indicate a revalidated response. Read more [here](/logs/faq/common-calculations/#how-can-i-calculate-bytes-served-by-the-origin-from-cloudflare-logs). | |
| Number of bytes returned by the origin server. Consider using CacheResponseBytes and filtering out OriginResponseStatus with values 0 and 304, which indicate a revalidated response. For more information, refer to [Calculating bytes served by the origin](/logs/faq/common-calculations/#how-can-i-calculate-bytes-served-by-the-origin-from-cloudflare-logs). |
|
Done. I posted a review on PR #30910. What the PR changes
Labels Issues flagged
|
|
Preview URL: https://fcdc3ce9.preview.developers.cloudflare.com Files with changes (up to 15) |
2 participants
Summary
Automated sync of Logpush dataset field definitions from data/entities.
Updated fields in existing datasets
DeviceRegistrationProfileID.MatchedRules.Files changed
src/content/docs/logs/logpush/logpush-job/datasets/{account,zone}/— dataset pagessrc/content/changelog/logs/2026-05-19-log-fields-updated.mdx— changelogDocumentation checklist