fix: use permissions: write in bonk instead of CODEOWNERS#30926
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
No issues found. The change correctly addresses the false-positive failures for team-member codeowners.
Follow-up: the bonk job on line 90 still uses permissions: CODEOWNERS and may fail for the same reason when team members invoke /bonk. Consider aligning both jobs in a future PR.
|
Review completed for PR #30926.
Summary: The change is correct and well-explained. Replacing Follow-up noted: The regular |
|
Preview URL: https://a6401779.preview.developers.cloudflare.com |
|
/bonk review |
|
Review posted for PR #30926. The change is correct. Both No issues found — the PR is ready to merge. |
Summary
The
bonk-auto-reviewjob was failing with exit code 1 for contributors who are codeowners via team membership (e.g.jhutchings1). The ask-bonk action's internalpermissions: CODEOWNERScheck does a flat string match against the CODEOWNERS file and does not resolve GitHub team membership, so it rejects valid codeowners listed via team references like@cloudflare/product-owners. Cloudflare-Studio/ask-bonk#173Replaces
permissions: CODEOWNERSwithpermissions: writein the bonk steps. Thewritecheck uses GitHub's actual permissions API, which correctly resolves team membership. Generally speaking, all CODEOWNERS should have write access. This also serves as defense-in-depth alongside the job-levelif:condition which gates onneeds.check-codeowner.outputs.is-codeowner == 'true'.