feat(metrics-registry): introduce stable registry crate with protobuf model#228
Merged
Merged
Conversation
TheJokr
approved these changes
Jul 9, 2026
Collaborator
|
/bonk run cargo fmt and fix clippy lints that crop up in the "Clippy checks" CI job. amend the changes to the previous commit. E: ah too bad, bonk refuses to push commits to PRs from forks :/ |
Contributor
|
@TheJokr Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new crate,
foundations-metrics-registry, to provide a stable, minimal core for Prometheus-compatible metrics serialisation in thefoundationsproject. Currently, the crate only includes vendored Prometheus protobuf definitions, a build script to generate Rust types, and exposes these types for use by other crates. It also updates the workspace configuration and dependencies accordingly.New crate:
foundations-metrics-registryfoundations-metrics-registrycrate to the workspace, with its ownCargo.tomland minimal dependencies, focused on stability and compatibility across major versions.Protobuf integration
metrics.protofile inproto/metrics.proto, providing the canonical wire format for metrics serialisation.build.rsscript usingprotoxandprost-buildto generate Rust types from the vendored protobuf at build time.src/proto/mod.rs, including a test verifying round-trip serialisation of the (native) histogram type.src/proto/model.rsvia a build-timeinclude!macro.Dependency and edition updates
prost,prost-build,prost-types, andprotoxfor protobuf code generation.