fix(styles): show pointer cursor on clickable elements#520
Conversation
| input[type="button"], | ||
| input[type="submit"], | ||
| input[type="reset"], |
There was a problem hiding this comment.
minor: I would include these two here as well
input[type="checkbox"],
input[type="radio"],|
/bonk review |
commit: |
There was a problem hiding this comment.
LGTM! This is a nice accessibility improvement that provides consistent pointer cursor affordances across the component library.
What I like:
- Uses
:where()for low specificity, making it easy for consumers to override when needed - Properly scoped to Kumo components via
[class*="kumo-"]and.link-currentselectors - Comprehensive coverage of both native elements and ARIA roles
- Correctly excludes disabled elements via multiple attribute checks (
:disabled,[disabled],[aria-disabled="true"],[data-disabled]) - Eduardo's feedback about including
input[type="checkbox"]andinput[type="radio"]has been addressed
Notes:
- The selector chain is quite long but this is acceptable given the low specificity approach with
:where() - The changeset properly documents this as a patch-level fix
Approving for merge.
|
I've submitted an approving review for PR #520. Summary of the review: This is a solid accessibility improvement that adds consistent pointer cursor affordances to clickable elements within Kumo components. The implementation uses
Eduardo's earlier feedback about including |
Docs PreviewCommit: |















Summary
:where()rule so clickable native and ARIA elements use the pointer cursor by default.aria-disabled, anddata-disabledelements.@cloudflare/kumo.Testing
pnpm exec prettier --check packages/kumo/src/styles/kumo.css .changeset/clickable-cursor.mdpnpm --filter @cloudflare/kumo lint(3 existing warnings, no errors)pnpm --filter @cloudflare/kumo buildReviews
bonk has reviewed the change
automated review not possible because: small CSS-only affordance update
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: not applicable
Additional testing not necessary because: covered by formatting, lint, and package build