Skip to content

Fix getProcess() throwing error in RPC transport#702

Merged
aron-cf merged 1 commit into
mainfrom
rpc-fix-get-process
May 19, 2026
Merged

Fix getProcess() throwing error in RPC transport#702
aron-cf merged 1 commit into
mainfrom
rpc-fix-get-process

Conversation

@aron-cf
Copy link
Copy Markdown
Contributor

@aron-cf aron-cf commented May 18, 2026

This method is supposed to return null if the transport does not exist
but the RPC implementation propagates errors from the RPC client. This
commit fixes the error and adds a basic regression test.


Open in Devin Review

This method is supposed to return `null` if the transport does not exist
but the RPC implementation propagates errors from the RPC client. This
commit fixes the error and adds a basic regression test.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

⚠️ No Changeset found

Latest commit: 1046962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@whoiskatrin
Copy link
Copy Markdown
Collaborator

LGTM, thanks for the fix 🙇🏼‍♀️

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 18, 2026

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@702

commit: 1046962

@github-actions
Copy link
Copy Markdown
Contributor

📦 Preview Build

Version: 0.0.0-pr-702-1046962

Install the SDK preview:

npm i https://pkg.pr.new/cloudflare/sandbox-sdk/@cloudflare/sandbox@702

🐳 Docker images were not rebuilt — no container changes detected. Use the latest release images from Docker Hub.

@aron-cf aron-cf enabled auto-merge (squash) May 18, 2026 21:28
@aron-cf aron-cf merged commit 06996cf into main May 19, 2026
55 of 63 checks passed
@aron-cf aron-cf deleted the rpc-fix-get-process branch May 19, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants