Skip to content

Fix AlwaysListMatcher behavior #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean0407 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AlwaysListMatcher behavior #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/src/list_matcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ impl ListDefinition for AlwaysList {

impl ListMatcher for AlwaysListMatcher {
fn match_value(&self, _: &str, _: &LhsValue<'_>) -> bool {
false
true
}

fn clear(&mut self) {}
Expand Down
16 changes: 16 additions & 0 deletions engine/src/scheme.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2070,6 +2070,22 @@ fn test_scheme_json_rejects_invalid_identifier() {
assert!(err.to_string().contains("invalid identifier 1invalid"));
}

#[test]
fn test_always_list_matches() {
use crate::{AlwaysList, ExecutionContext};

let mut builder = Scheme! { num: Int };
builder.add_list(Type::Int, AlwaysList {}).unwrap();
let scheme = builder.build();

let filter = scheme.parse("num in $numbers").unwrap().compile();
let mut ctx = ExecutionContext::new(&scheme);
ctx.set_field_value(scheme.get_field("num").unwrap(), 42)
.unwrap();

assert_eq!(filter.execute(&ctx), Ok(true));
}

#[test]
fn test_nil_not_equal_behavior_true() {
use crate::{Array, ExecutionContext, Map};
Expand Down