fix: fix entropy patch for newer pydantic versions#153
Open
ryanking13 wants to merge 1 commit into
Open
Conversation
|
I've reviewed the changes carefully. Let me analyze: Changes in
Changes in Removes the early-return guard that skipped entropy patch tests on Python 3.14, since the fix should now make them pass. Review assessment: The logic is sound:
I don't see any logic bugs, security issues, backward compatibility problems, or other actionable issues. LGTM |
hoodmane
reviewed
Jul 9, 2026
Comment on lines
+97
to
+98
| # pydantic-core >=2.41 no longer exports validate_core_schema. Build a | ||
| # tiny validator instead so any lazy hash-map seeds are initialized |
Contributor
There was a problem hiding this comment.
Suggested change
| # pydantic-core >=2.41 no longer exports validate_core_schema. Build a | |
| # tiny validator instead so any lazy hash-map seeds are initialized | |
| # Build a tiny validator instead so any lazy hash-map seeds are initialized |
Contributor
There was a problem hiding this comment.
Can we just delete the other branch? This should work always.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #129. It fixes pydantic-core entropy patch so that we can use fastapi in python 3.14