Remove wasm bindgen futures#1001
Open
guybedford wants to merge 2 commits into
Open
Conversation
worker-build sets WASM_BINDGEN_USE_JS_SYS=1, so the #[wasm_bindgen] macro emits js_sys::futures glue directly and the worker crate no longer needs wasm-bindgen-futures. Drop the dependency and the re-export, and migrate the remaining direct users to js_sys::futures.
guybedford
force-pushed
the
remove-wasm-bindgen-futures
branch
from
165d961 to
c4cbcdb
Compare
Merging this PR will not alter performance
|
worker-build only sets the env var for the wasm build, but plain `cargo check`/`cargo clippy` also expand #[wasm_bindgen] on async fns (e.g. email.rs) and the generated glue references wasm_bindgen_futures. Set the opt-in in .cargo/config.toml [env] so the proc-macro emits js_sys::futures glue for host builds too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the use of the
wasm-bindgen-futurescrate, with the last commit based to #999 and using PR wasm-bindgen/wasm-bindgen#5164.