Unhide cache config#13055
Conversation
🦋 Changeset detectedLatest commit: 3f3e764 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
✅ All changesets look good |
|
UnknownError: "Internal server error" |
|
@GregBrimble Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR removes the @hidden JSDoc tag from the cache configuration option and adds a changeset.
Issues:
- Placeholder URL in changeset — The changeset contains
[our documentation](TODO)which will be published verbatim into the changelog for both@cloudflare/workers-utilsandwrangler. This needs to be replaced with the actual docs URL (or the link removed entirely) before merging.
|
I'm Bonk, and I've done a quick review of your PR. This PR removes the |
petebacondarwin
left a comment
There was a problem hiding this comment.
Happy to approve once the documentation links are up.
|
What's the status here @GregBrimble ? |
|
We've got the docs links now! Updated the PR description and changeset. Still not ready to land yet, but it's review-ready now. |
5b004f5 to
d261484
Compare
|
CI is thoroughly broken. Please mark as "ready for review" when it is good to go. Shouldn't take long to review. |
338919c to
0693d68
Compare
|
Hi @GregBrimble — we're doing some cleanup of stale draft PRs. This PR has been quiet since 2026-04-23. Could you let us know within 14 days whether you're still planning to continue?
Thanks! |
0693d68 to
8c7f2e6
Compare
|
Rebased. Yes, it's still active. In fact, I see other features haven't waited on unhiding before being available server-side, so let's just go ahead and review and land this now. |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
petebacondarwin
left a comment
There was a problem hiding this comment.
Nits - nothing blocking.
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
8c7f2e6 to
7b41cbc
Compare
7b41cbc to
3f3e764
Compare
Fixes WC-4623.
Unhides the
cacheconfiguration option for Workers.A picture of a cute animal (not mandatory, but encouraged)