Skip to content

Unhide cache config#13055

Merged
petebacondarwin merged 3 commits into
mainfrom
unhide-cache-config
May 5, 2026
Merged

Unhide cache config#13055
petebacondarwin merged 3 commits into
mainfrom
unhide-cache-config

Conversation

@GregBrimble
Copy link
Copy Markdown
Contributor

@GregBrimble GregBrimble commented Mar 25, 2026

Fixes WC-4623.

Unhides the cache configuration option for Workers.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: no tests for schema changes
  • Public documentation

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@GregBrimble GregBrimble requested a review from a team as a code owner March 25, 2026 17:08
@GregBrimble GregBrimble requested a review from vicb March 25, 2026 17:08
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: 3f3e764

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/workers-utils/src/config/environment.ts: [@cloudflare/wrangler]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

✅ All changesets look good

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Mar 25, 2026

UnknownError: "Internal server error"

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Mar 25, 2026

@GregBrimble Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread .changeset/twenty-spies-rest.md Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 25, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13055

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13055

miniflare

npm i https://pkg.pr.new/miniflare@13055

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13055

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13055

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13055

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13055

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13055

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13055

wrangler

npm i https://pkg.pr.new/wrangler@13055

commit: 3f3e764

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

This PR removes the @hidden JSDoc tag from the cache configuration option and adds a changeset.

Issues:

  1. Placeholder URL in changeset — The changeset contains [our documentation](TODO) which will be published verbatim into the changelog for both @cloudflare/workers-utils and wrangler. This needs to be replaced with the actual docs URL (or the link removed entirely) before merging.

Comment thread .changeset/twenty-spies-rest.md Outdated
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Mar 25, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR removes the @hidden JSDoc tag from the cache configuration option and adds a changeset. The code change itself is clean — the only actionable issue is the TODO placeholder URL in the changeset that would be published to the changelog. I've posted a suggestion comment on the PR with a fix.

github run

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve once the documentation links are up.

@petebacondarwin petebacondarwin requested review from petebacondarwin and removed request for vicb April 15, 2026 08:05
@petebacondarwin
Copy link
Copy Markdown
Contributor

What's the status here @GregBrimble ?

@petebacondarwin petebacondarwin marked this pull request as draft April 15, 2026 11:29
@GregBrimble
Copy link
Copy Markdown
Contributor Author

We've got the docs links now! Updated the PR description and changeset. Still not ready to land yet, but it's review-ready now.

@GregBrimble GregBrimble force-pushed the unhide-cache-config branch from 5b004f5 to d261484 Compare April 20, 2026 15:12
@petebacondarwin
Copy link
Copy Markdown
Contributor

CI is thoroughly broken. Please mark as "ready for review" when it is good to go. Shouldn't take long to review.

@GregBrimble GregBrimble force-pushed the unhide-cache-config branch 2 times, most recently from 338919c to 0693d68 Compare April 23, 2026 18:03
@petebacondarwin
Copy link
Copy Markdown
Contributor

Hi @GregBrimble — we're doing some cleanup of stale draft PRs.

This PR has been quiet since 2026-04-23. Could you let us know within 14 days whether you're still planning to continue?

  • If yes: please leave a comment with a status update or push a rebase, and we'll keep it open.
  • If no: no need to reply — we'll close it after 14 days, and you can always reopen later if you pick it back up.

Thanks!

@GregBrimble GregBrimble force-pushed the unhide-cache-config branch from 0693d68 to 8c7f2e6 Compare May 4, 2026 13:34
@GregBrimble GregBrimble marked this pull request as ready for review May 4, 2026 13:35
@GregBrimble
Copy link
Copy Markdown
Contributor Author

Rebased. Yes, it's still active. In fact, I see other features haven't waited on unhiding before being available server-side, so let's just go ahead and review and land this now.

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented May 4, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - nothing blocking.

Comment thread packages/wrangler/src/preview/preview.ts Outdated
Comment thread packages/wrangler/src/preview/preview.ts Outdated
Comment thread packages/wrangler/src/preview/shared.ts Outdated
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@GregBrimble GregBrimble force-pushed the unhide-cache-config branch from 8c7f2e6 to 7b41cbc Compare May 5, 2026 17:35
@petebacondarwin petebacondarwin merged commit f3fed88 into main May 5, 2026
58 of 60 checks passed
@petebacondarwin petebacondarwin deleted the unhide-cache-config branch May 5, 2026 20:30
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants