Skip to content

ci: no more latest tag on image, use windows-2019 - #182

Merged
mkocher merged 1 commit into
windows-2019from
fix-ci-image-build-2
Jun 16, 2026
Merged

ci: no more latest tag on image, use windows-2019#182
mkocher merged 1 commit into
windows-2019from
fix-ci-image-build-2

Conversation

@mkocher

@mkocher mkocher commented Jun 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e6e79c14-4672-4474-a584-9f2e0a3f70e5

📥 Commits

Reviewing files that changed from the base of the PR and between 16ac480 and c75c68d.

📒 Files selected for processing (2)
  • ci/docker/additional-tags
  • ci/pipelines/stemcells-windows.yml
💤 Files with no reviewable changes (2)
  • ci/docker/additional-tags
  • ci/pipelines/stemcells-windows.yml

Walkthrough

In the build-windows-stemcell-ci-image pipeline job, the put step for bosh-windows-stemcell-builder-ci-image is updated to remove the additional_tags parameter (which referenced a file containing the latest tag) and to add no_get: true. The associated ci/docker/additional-tags file, which previously held the latest tag value, is also deleted.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to verify if it relates to the changeset. Add a description explaining why the 'latest' tag is being removed and how windows-2019 targeting improves the CI/CD process.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing the 'latest' tag from CI image builds and targeting windows-2019 instead.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci-image-build-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkocher
mkocher merged commit dcb03f3 into windows-2019 Jun 16, 2026
15 checks passed
@mkocher
mkocher deleted the fix-ci-image-build-2 branch June 16, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants