Skip to content

cleanup vestigial additional-tags - #185

Merged
mkocher merged 1 commit into
windows-2019from
fix-ci-image-build-3
Jun 16, 2026
Merged

cleanup vestigial additional-tags#185
mkocher merged 1 commit into
windows-2019from
fix-ci-image-build-3

Conversation

@mkocher

@mkocher mkocher commented Jun 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 199ceb72-60f4-47f8-ba7c-f4f772c27563

📥 Commits

Reviewing files that changed from the base of the PR and between ed52eb7 and 93c2106.

📒 Files selected for processing (1)
  • ci/pipelines/stemcells-windows.yml
💤 Files with no reviewable changes (1)
  • ci/pipelines/stemcells-windows.yml

Walkthrough

In ci/pipelines/stemcells-windows.yml, the put step for bosh-windows-stemcell-builder-ci-image within the build-windows-stemcell-ci-image job is updated to explicitly set no_get: true and specify the pushed image via params.image: image/image.tar. The additional_tags configuration that previously sourced tag values from bosh-windows-stemcell-builder-dockerfiles/ci/docker/additional-tags is removed.

Suggested reviewers

  • aramprice
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the rationale for removing the additional-tags configuration and its impact.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'cleanup vestigial additional-tags' accurately describes the main change: removal of the additional-tags configuration from the CI pipeline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci-image-build-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jun 16, 2026
@mkocher
mkocher merged commit ed52eb7 into windows-2019 Jun 16, 2026
17 checks passed
@mkocher
mkocher deleted the fix-ci-image-build-3 branch June 16, 2026 21:09
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant