make ssh user cleanup acceptance test retry to avoid race condition

[mkocher]

This has failed occasionally in CI, presumably because the user has not been cleaned up yet but will be soon. Also corrected the comment to match the implementation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59a0afe0-566d-4b12-9629-47ab6c0a03e5

📥 Commits

Reviewing files that changed from the base of the PR and between ed52eb7 and dc02120.

📒 Files selected for processing (1)

• acceptance_test/main_test.go

---

Walkthrough

In the "ssh enabled" acceptance test case, the check-ssh errand execution is changed from a single synchronous RunErrand call with an immediate assertion to a retrying Eventually block. The test now polls boshCommand.RunErrand("check-ssh", deploymentName) every 10 seconds for up to 2 minutes, asserting success via Should(Succeed()). A comment was also added describing the verification intent around C:\Users and net users having no bosh_* users.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: adding retry logic to the SSH user cleanup acceptance test to avoid a race condition.
Description check	✅ Passed	The description explains the rationale for the change (occasional CI failures due to race condition) and mentions a comment correction, which aligns with the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch add-test-retry

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}