chore: Change all remaining internal uses of aria-live to LiveRegion component#4470
Open
avinashbot wants to merge 2 commits into
Open
chore: Change all remaining internal uses of aria-live to LiveRegion component#4470avinashbot wants to merge 2 commits into
avinashbot wants to merge 2 commits into
Conversation
9a02363 to
94d57b7
Compare
avinashbot
commented
Apr 27, 2026
| ) : null} | ||
| </InternalSpaceBetween> | ||
|
|
||
| <div aria-live="polite"> |
Member
Author
There was a problem hiding this comment.
After a bit of manual testing, I'm honestly not sure why this was wrapped with an aria-live — there's nothing dynamically changing in the tutorial list. I believe the purpose this was supposed to serve was essentially replaced by the newly added focus-on-complete behavior in #4167.
2763e70 to
039a1d6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4470 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 933 933
Lines 29486 29493 +7
Branches 10697 10699 +2
=======================================
+ Hits 28720 28727 +7
Misses 759 759
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NathanZlion
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Also added a new internal LiveRegion API,
preventInitialAnnouncement. May externalize it if it proves helpful, but for now, it's internal-only and opt-in.Related links, issue #, if available: AWSUI-22299
How has this been tested?
Kept existing tests, which should continue working. Manually tested the two cases on VoiceOver.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.