fix: Remove underline from trailing whitespace in external links#4497
Draft
avinashbot wants to merge 3 commits into
Draft
fix: Remove underline from trailing whitespace in external links#4497avinashbot wants to merge 3 commits into
avinashbot wants to merge 3 commits into
Conversation
Removes the non-breaking space that caused underlines to appear below trailing whitespace between external icon and link text. Replaces it with margin-inline-start. AWSUI-60840
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4497 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 933 933
Lines 29595 29595
Branches 10757 10756 -1
=======================================
Hits 28831 28831
- Misses 716 757 +41
+ Partials 48 7 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resurrecting a contribution in #3709 that neither I nor the contributor could find a path forward for. While spending time investigating a fix for #4496, I discovered a trick that lets us do this without a space (apparently this character existed for many years now, just hadn't come across it until just now).
Keeping the original commit in there to maintain the attribution to the original contributor who kicked it off.
Related links, issue #, if available: AWSUI-60840
How has this been tested?
Would definitely show up in screenshot tests.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.