fix: remediate CLI, provider, and metrics audit findings#16
Merged
Conversation
cluic
marked this pull request as ready for review
July 19, 2026 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit findings resolved
Reported defects
isDirectExecution()compare a real module path with an unresolved symlink path, suppressingrunCli().activateIfNone, so the following explicit activation hitCODEX_NOT_READYwhile Codex was unconfigured.Additional findings
modelMode/modelOverridedid not survive every registry -> service -> Worker snapshot boundary.Connectiontokens could reintroduce hop-by-hop headers.Verification
npm test: 519/519 (458unit-core +9isolated Capture +51integration +1serial core chain)npm run lint: 33 source filesnpm run typecheck:ui: passnpm run verify:ui-build: exact three-file output passnpm audit --omit=dev: 0 vulnerabilitiesnpm pack --dry-run --json --ignore-scripts: exact reviewed 34-file packageorigin/main: minorgit diff --check, production/staged sensitive-pattern scans, fixed-port cleanup, desktop/mobile visual QA: passRisk and boundaries
Merge risk is L3 because this changes the proxy data plane, Worker runtime snapshots, and Provider lifecycle-adjacent behavior. The PR intentionally remains draft for human review and the repository's external release gates.
Node versions without native zstd conservatively skip semantic inspection for unsupported checksummed or multi-frame fallback cases while preserving byte-exact forwarding. Local tests use temporary roots, synthetic credentials, and loopback upstreams; they do not replace copied-real-history or external-upstream evidence.