Skip to content

Pr groups#1666

Merged
prandla merged 18 commits intocms-dev:mainfrom
prandla:pr-groups
Apr 5, 2026
Merged

Pr groups#1666
prandla merged 18 commits intocms-dev:mainfrom
prandla:pr-groups

Conversation

@prandla
Copy link
Copy Markdown
Member

@prandla prandla commented Apr 5, 2026

the same as #1621, but rebased on the new main, and i incorporated luca's last comment (changed the warning in italy_yaml.py to an error)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 31.87919% with 203 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.68%. Comparing base (4486dc1) to head (36ae571).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cms/server/admin/handlers/user.py 0.00% 84 Missing ⚠️
cmscontrib/loaders/italy_yaml.py 5.88% 32 Missing ⚠️
cmscontrib/AddParticipation.py 9.37% 29 Missing ⚠️
cms/server/admin/handlers/base.py 0.00% 11 Missing ⚠️
cmscontrib/ImportContest.py 56.00% 11 Missing ⚠️
cms/db/user.py 64.28% 10 Missing ⚠️
cms/server/admin/handlers/contestuser.py 0.00% 7 Missing ⚠️
cmstestsuite/functionaltestframework.py 0.00% 6 Missing ⚠️
cms/server/admin/handlers/contest.py 0.00% 5 Missing ⚠️
cms/server/contest/handlers/contest.py 0.00% 5 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   54.89%   54.68%   -0.22%     
==========================================
  Files         335      336       +1     
  Lines       27208    27450     +242     
==========================================
+ Hits        14937    15011      +74     
- Misses      12271    12439     +168     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 54.68% <31.87%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla prandla merged commit 727005d into cms-dev:main Apr 5, 2026
3 of 4 checks passed
@prandla prandla mentioned this pull request Apr 5, 2026
@prandla prandla deleted the pr-groups branch April 5, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants