This repository was archived by the owner on May 3, 2022. It is now read-only.
Refactoring: move docker driver Simulate field as a config parameter.#673
Open
silvin-lubecki wants to merge 1 commit into
Open
Refactoring: move docker driver Simulate field as a config parameter.#673silvin-lubecki wants to merge 1 commit into
silvin-lubecki wants to merge 1 commit into
Conversation
Contributor
Author
|
@michelleN I don't understand your comment, I already made this change, is it right? |
Contributor
Author
|
PTAL @michelleN @radu-matei |
radu-matei
suggested changes
Mar 26, 2019
radu-matei
left a comment
radu-matei
left a comment
Member
There was a problem hiding this comment.
As the Simulate field is only present in the Docker driver, and there is already another way of passing config, I think we should be consistent -- and this approach is the most straightforward.
That being said, also have a look at the Docker driver test below:
$ make test
go test ./...
# github.com/deislabs/duffle/pkg/driver [github.com/deislabs/duffle/pkg/driver.test]
pkg/driver/driver_test.go:58:19: d.(*DockerDriver).Simulate undefined (type *DockerDriver has no field or method Simulate)
Thanks!
Contributor
Author
|
Woops, thank you for spotting that @radu-matei ! But that's weird the CI didn't catch it 🤔 |
Member
|
Curious how none of the two CIs kicked in at all. Investigating.. |
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
simulate-is-config
branch
from
c7f3a46 to
0bb798e
Compare
Contributor
Author
|
Should be fixed + rebased 👍 |
Contributor
Author
|
PTAL @radu-matei @michelleN |
1 similar comment
Contributor
Author
|
PTAL @radu-matei @michelleN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactoring, as I think this Simulate field has nothing to do here, since there's a config map for this kind of parameters.
Signed-off-by: Silvin Lubecki silvin.lubecki@docker.com