Open
Conversation
This comment was marked as spam.
This comment was marked as spam.
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
PhilippMatthes
commented
Apr 9, 2026
| CHART_PACKAGE=$(ls $CHART_DIR/*.tgz) | ||
| helm push $CHART_PACKAGE oci://${{ env.REGISTRY }}/${{ github.repository }}/charts/ | ||
| done | ||
|
|
Member
Author
There was a problem hiding this comment.
This workflow step is redundant with the one below. It can be removed.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Test Coverage ReportTest Coverage 📊: 68.8% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the initial scaffold for the placement api shim.
The shim's main entrypoint is placed under
cmd/shim/main.gomoving the original entrypoint tocmd/manager/main.go. This allows the shim and manager to be built into two separate images with different release cycles than the main controller-manager binary. Which binary is built and packaged into the docker image is controlled via a newGOMAINbuild arg.To onboard other shims in the future, such as a shim for our limes API or a shim for the nova external scheduler api,
internal/shimandcmd/shimis the place where the code should live. Ahelm/library/cortex-shimprovides the necessary scaffold to deploy any shim. We follow the same pattern as with the cortex manager chart, bundling this underhelm/bundles/cortex-placement-shimwith the necessary customization: placement-shim specific alerts, config, and rbac.Completing this scaffold, the image and charts are added to our gh workflow and the Tiltfile. Also, a basic kubebuilder manager scaffold has been added to
cmd/shim/main.go.