Skip to content

fix: transaction state on rollback (#364)#369

Open
BuonOmo wants to merge 1 commit into
7-1-stablefrom
backport-364-to-7-1
Open

fix: transaction state on rollback (#364)#369
BuonOmo wants to merge 1 commit into
7-1-stablefrom
backport-364-to-7-1

Conversation

@BuonOmo

@BuonOmo BuonOmo commented Mar 6, 2025

Copy link
Copy Markdown
Collaborator

Fixes #258

See #368

@BuonOmo BuonOmo requested a review from rafiss March 6, 2025 12:38
@rafiss

rafiss commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

I'm not quite sure why this error happened in the v23.2 test:

 /home/runner/work/activerecord-cockroachdb-adapter/activerecord-cockroachdb-adapter/vendor/bundle/ruby/3.5.0+0/bundler/gems/rails-f926c7902969/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:55:in 'PG::Connection#exec': PG::FeatureNotSupported: ERROR:  at or near "before_insert_trigger": syntax error: unimplemented: this syntax (ActiveRecord::StatementInvalid)
DETAIL:  source SQL:
CREATE TRIGGER before_insert_trigger

v23.2 does not support triggers, but I'm surprised the test tried using one on that version.

@BuonOmo

BuonOmo commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator Author

@rafiss yeah I didn't cherry pick everything on that one, I believe I should as well. I wanted to first focus on the 7-2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants