You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Potentially breaking change: the publish method now always returns a promise. Previously, it did not return a promise in some error cases. This should not impact most users.
Updates to the development dependencies required a minimum Node version of 14 for the tests. The library should still work on Node 12, but tests are no longer run in CI for version 12. A future major version of the library may drop support for version 12 altogether.
#395 - Switch from filenamify-url to filenamify (@tw0517tw)
v3.0.0
Breaking changes:
None really. But tests are no longer run on Node < 10. Development dependencies were updated to address security warnings, and this meant tests could no longer be run on Node 6 or 8. If you still use these Node versions, you may still be able to use this library, but be warned that tests are no longer run on these versions.
Potentially breaking change: the publish method now always returns a promise. Previously, it did not return a promise in some error cases. This should not impact most users.
Updates to the development dependencies required a minimum Node version of 14 for the tests. The library should still work on Node 12, but tests are no longer run in CI for version 12. A future major version of the library may drop support for version 12 altogether.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This major version upgrade transitions gh-pages to a pure ESM package and increases the minimum Node.js requirement to 16. While Codacy results indicate the PR is up to standards, the project's environment appears to rely on legacy dependencies (e.g., npm-run-all ^4.1.3), suggesting it may not yet support ESM or modern Node.js versions. There is a high risk that existing deployment scripts or CI pipelines will fail upon merging this change because the programmatic API and environment requirements have fundamentally changed since v1.x.
About this PR
The transition to gh-pages v5.0.0 is a major breaking change that shifts the package to ESM-only. Ensure that the project's build and deployment infrastructure is prepared for this transition, as it likely requires updates to how scripts are invoked or how the environment is configured.
Test suggestions
Verify that the project's documentation deployment script (likely using gh-pages CLI) still functions correctly under the new version.
Verify that the CI/CD pipeline runs on a compatible Node.js version (Node 16+) as required by the new gh-pages version for its own internal stability and testing.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the project's documentation deployment script (likely using gh-pages CLI) still functions correctly under the new version.
2. Verify that the CI/CD pipeline runs on a compatible Node.js version (Node 16+) as required by the new gh-pages version for its own internal stability and testing.
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM RISK
This major version upgrade transitions gh-pages to a pure ESM package and increases the minimum Node.js requirement to 16. Given the legacy nature of other dependencies in this file (such as npm-run-all and codacy-coverage from 2018), this change will likely break CommonJS-based scripts or CI pipelines running on older Node.js versions. Check if the project uses CommonJS require('gh-pages') or runs on Node.js < 16. If so, either upgrade the environment to ESM/Node 16+ or revert gh-pages to a version compatible with the current setup (e.g., v2.x or v3.x).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filejavascriptPull requests that update javascript code
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot
Bot
added
dependencies
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Bumps gh-pages from 1.2.0 to 5.0.0.
Release notes
Sourced from gh-pages's releases.
... (truncated)
Changelog
Sourced from gh-pages's changelog.
... (truncated)
Commits
f729b975.0.051534c7Log changesace063bMerge pull request #438 from Vicropht/patch-158e54beMerge pull request #459 from tschaub/dependabot/npm_and_yarn/async-3.2.42189df3Bump async from 2.6.4 to 3.2.4051846eMerge pull request #454 from tschaub/dependabot/npm_and_yarn/email-addresses-...5c91c67Merge pull request #455 from tschaub/dependabot/github_actions/actions/setup-...fe0ad83Merge pull request #453 from tschaub/dependabot/github_actions/actions/checko...b89287dMerge pull request #445 from Nezteb/patch-1e890bd1Bump email-addresses from 3.0.1 to 5.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.