fix withdrawal queue and filtered responses#609
Open
Sadeequ wants to merge 2 commits into
Open
Conversation
|
@Sadeequ is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Sadeequ Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a global exception filter for NestJS that catches all unhandled exceptions and returns a consistent JSON error envelope. The filter:
Uses @catch() without arguments to capture every exception type
Leverages HttpAdapterHost for compatibility with any HTTP adapter (Express/Fastify)
Returns a standardized error structure containing:
statusCode (HTTP status)
message (error description)
errorCode (custom code or status code as string)
timestamp (ISO 8601 format)
path (request URL)
requestId (unique identifier for correlation)
Extracts or generates a requestId from headers (x-request-id), request.id, or creates one
Logs errors with the requestId for traceability, including stack traces in development
Strips stack traces from production responses while logging them server-side
Is already registered globally in main.ts via app.useGlobalFilters()
The implementation meets all acceptance criteria: consistent error envelopes for 4xx/5xx responses, stripped stack traces in production with server-side logging, and requestId correlation. Note that the build currently shows pre-existing errors in other files unrelated to this change.
Related Issue:
CLOSES #478
CLOSES #479