Skip to content

feat: admin can add hr#546

Open
devsharmagit wants to merge 6 commits into
code100x:mainfrom
devsharmagit:feat/admin-add-hr
Open

feat: admin can add hr#546
devsharmagit wants to merge 6 commits into
code100x:mainfrom
devsharmagit:feat/admin-add-hr

Conversation

@devsharmagit

Copy link
Copy Markdown
Contributor

closes #521

here is a video showcase

ccccccccc.mp4

@devsharmagit

Copy link
Copy Markdown
Contributor Author

@VineeTagarwaL-code
I tried to solve admin can add HR issue.

@VineeTagarwaL-code

Copy link
Copy Markdown
Contributor

Nice

@VineeTagarwaL-code

Copy link
Copy Markdown
Contributor

reviewing the code and merging

@VineeTagarwaL-code

Copy link
Copy Markdown
Contributor

will test out locally once to make sure everything is good !

@VineeTagarwaL-code

Copy link
Copy Markdown
Contributor

fix conflicts will merge

@devsharmagit

Copy link
Copy Markdown
Contributor Author

@VineeTagarwaL-code
fixed conflicts and build

@VineeTagarwaL-code

Copy link
Copy Markdown
Contributor

checking and merging if everything feels fine

@VineeTagarwaL-code

Copy link
Copy Markdown
Contributor

Broken -

  1. add validation error properly
  2. generated password doesnt matches and throws incorrect email or password error
  3. make the font size little bigger for bigger desktop

@devsharmagit

Copy link
Copy Markdown
Contributor Author

@VineeTagarwaL-code
done the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: admin can add hr feature

2 participants