Resolve assigned issues #167, #174, #175, and #180#1
Open
codeX-james wants to merge 1 commit into
Open
Conversation
Improve dashboard search/filter/sort URL persistence, enforce pause checks for deposit/withdraw with new pause tests, add frontend error handling and boundary tests, and document the contract upgrade runbook with deployment/readme links. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes astera-hq#167
Closes astera-hq#174
Closes astera-hq#175
Closes astera-hq#180
Summary
depositandwithdraw, document pause policy in-contract, and add pause consistency tests for blocked user ops and allowed admin ops.ErrorBoundarycomponent plus tests, and extend store failure-path tests.docs/contract-upgrade-guide.mdand link it fromdocs/mainnet-deployment.mdandREADME.md.Test plan
ReadLintson all touched files (no lints reported)npm --prefix frontend test -- --runTestsByPath __tests__/lib/dashboardFilters.test.ts __tests__/lib/contracts.test.ts __tests__/components/error-boundary.test.tsx __tests__/lib/store.test.tsx(blocked in this environment:jestnot installed)cargo test -p pool test_deposit_blocked_when_pausedcargo test -p pool test_withdraw_blocked_when_pausedcargo test -p pool test_admin_ops_allowed_when_pausedcontracts/pool/tests/fuzz_tests.rs(repay_invoicecall missing the amount argument)Made with Cursor