Fix issues #170 #174 #209 #212 (assigned)#1
Open
codeX-james wants to merge 3 commits into
Open
Conversation
…s, and revenue deposits. This switches admin updates to a two-step transfer to prevent accidental lockout, clears stale revenue-claimed state on refunds, and adds coverage for deadline/withdrawn vote gating plus repeated revenue deposits. Made-with: Cursor
This applies rustfmt output so the build-and-test workflow passes cargo fmt --check on the PR branch. Made-with: Cursor
This aligns the four newly added tests with the upstream create_campaign signature used in CI. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_adminwith a safe two-step flow (initiate_admin_transfer,accept_admin_transfer,cancel_admin_transfer) backed byPendingAdminstorageRevenueClaimedstate onclaim_refundby removing the persistent key, and add regression coverage for refund cleanup behaviordeposit_revenueaccumulation/event emission and forvote_on_campaignrejection after deadline and after funds withdrawalTest plan
cargo test --quietLinked upstream issues
Made with Cursor