feat(tests): add full multisig flow test suite with scenarios for pro…#254
Open
samieazubike wants to merge 1 commit into
Open
feat(tests): add full multisig flow test suite with scenarios for pro…#254samieazubike wants to merge 1 commit into
samieazubike wants to merge 1 commit into
Conversation
|
@samieazubike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…posal lifecycle
Description
Adds a dedicated multisig-flow test suite for the
group_treasurycontract (closes #127). The newmod multisig_flowincontracts/contracts/group_treasury/src/test.rscovers all 10 scenarios from the issue, reusing the existingvoting_setup/seed_proposal/mock_tokenhelpers. No production contract code is changed.4 active, passing tests (against currently-implemented APIs):
multisig_approvals_reach_threshold_passes— approvals reaching threshold flip toPassed(scenario 3)multisig_double_vote_panics— a member voting twice panics (scenario 4)multisig_rejection_blocks_proposal— rejections reaching the blocking minority flip toRejected(scenario 5)multisig_approve_after_expiry_panics— approving after expiry panics (scenario 9)6 documented, ignored stubs carrying an explicit
#[ignore = "blocked on …"]reason and the exact ledger-sequence (set_sequence_number/ttl_ledgers) assertions to enable once their dependencies land:multisig_propose_by_member,multisig_propose_by_non_member_panics— blocked on Implementpropose_withdrawon Group Treasury contract #122 (propose_withdraw)multisig_execute_on_approved,multisig_execute_on_pending_panics— blocked on a group_treasury execute entrypoint (no issue yet)multisig_finalize_expired— blocked on an expiry finalizer (no issue yet)multisig_get_pending_proposals_filtering— blocked onget_pending_proposals(no issue yet)The stub bodies call no not-yet-generated client methods, so the crate compiles cleanly.
Verification
cargo test -p group_treasury→ 35 passed, 6 ignored, 0 failedcargo fmt -p group_treasury -- --check→ cleancargo clippy -p group_treasury --tests→ no warningsType of change
Checklist