Enhance message_read handling: monotonic read cursor, privacy-aware r…#258
Open
martinshub-tech wants to merge 2 commits into
Open
Enhance message_read handling: monotonic read cursor, privacy-aware r…#258martinshub-tech wants to merge 2 commits into
martinshub-tech wants to merge 2 commits into
Conversation
…ead receipts, schema update, test env fallbacks
|
@martinshub-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #186
Changes Overview
apps/backend/src/socket/messaging.ts
Imported the users table.
Implemented monotonic read cursor logic to prevent the read cursor from moving backwards.
Added per‑user privacy setting (sendReadReceipts) to conditionally broadcast read_receipt events.
Safe user lookup with fallback handling.
apps/backend/src/db/schema.ts
Added sendReadReceipts boolean column to the users table (default true).
Test environment fallbacks
apps/backend/src/lib/jwt.ts – provides a default secret (test‑secret) and ensures process.env.JWT_SECRET is set for tests.
apps/backend/src/db/index.ts – supplies a fallback PostgreSQL connection string for test runs.
package.json
Added missing dev‑dependencies:
supertest
express
jsonwebtoken
ioredis
@stellar/stellar-sdk
vitest
Updated imports and added necessary safeguards.