feat-POST /uploads/:fileId/complete — confirm + verify#259
Open
muhsar27 wants to merge 1 commit into
Open
Conversation
|
@muhsar27 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Description
This PR introduces the backend file upload confirmation and verification flow.
POST /uploads) to request a presigned URL and generate apendingfile record in the database.POST /uploads/:id/completefor the client to confirm an upload. The server verifies the object's presence andContentLengthin S3 against the expected size before marking the file asready. If there's a size or hash mismatch, a 400 error is returned and the file remainspending.pendingfiles that are older than 1 hour.messagescan only referencefileIds that have been verified and marked asready.Type of change
Checklist