feat: add proposal expiry mechanism and finalize_expired_proposal#260
Merged
codebestia merged 1 commit intoJun 28, 2026
Merged
Conversation
Add finalize_expired_proposal to proposals contract to transition Pending proposals to Expired after expiry. Update group_treasury to panic when attempting to vote on an Expired proposal.
|
@eischideraa-unn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
codebestia
approved these changes
Jun 28, 2026
codebestia
left a comment
codebestia
left a comment
Owner
There was a problem hiding this comment.
LGTM!
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces proposal expiry functionality to the codebase. It adds finalize_expired_proposal to the
proposals contract, allowing anyone to transition Active (pending) proposals that have surpassed their
expires_at timestamp to an Expired status. Correspondingly, the group_treasury contract has been updated to
panic if a member attempts to vote on a proposal that has already expired.
Closes #126
Type of change
Checklist