#219 Typing indicators (ephemeral, never stored) FIXED#261
Open
felladaniel36-hash wants to merge 2 commits into
Open
Conversation
|
@felladaniel36-hash Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…-never-stored)-FIX
Author
|
PLEASE REVIEW... AND PING ME BACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented real-time
typing_startandtyping_stopSocket.IO event handling relayed via Pub/Sub conversation rooms with strictly zero database writes:messaging.tswith explicit payload construction{ conversationId, userId, ...(deviceId ? { deviceId } : {}) }, permanently guaranteeing that draft messagecontentis never relayed. Fast-path verifies room membership viasocket.rooms.has(conversationId)to avoid unnecessary database queries.typingTimerstracking active typing sessions with a 5-second inactivity timeout. Automatically dispatchestyping_stopupon timer expiration, and instantly clears typing indicators when a socket disconnects or emitssend_message.MessageInput.tsxwith debounced timers (2000ms delay) to emit real-time typing events as users type and immediately stop typing indicators upon sending text or confirming Soroban token transfers.conversations.tsandtreasury.ts.apps/backend/src/__tests__/typing.test.tsvalidating all acceptance criteria (zero DB writes, timeout auto-clearing, room-member isolation, content stripping, and disconnect cleanup).Type of change
Bug fix
New feature
Documentation update
Other
Checklist
I have read the contributing guidelines
I have tested my changes locally
My code follows the project's coding standards
CLOSE #219