feat: implement propose_withdraw on GroupTreasuryContract (#122)#274
Open
Kayce10 wants to merge 1 commit into
Open
feat: implement propose_withdraw on GroupTreasuryContract (#122)#274Kayce10 wants to merge 1 commit into
Kayce10 wants to merge 1 commit into
Conversation
…#122) - Add ProposalCreatedEvent to storage.rs - Implement propose_withdraw(env, proposer, to, token, amount, ttl_ledgers) -> u32 - Verifies proposer is a member (panics 'proposer is not a member') - Validates amount > 0 - Checks sufficient treasury balance (panics 'insufficient funds') - Reads ProposalCount for new ID, increments it - Creates WithdrawProposal with Active status, approvals=1 (proposer auto-approved) - Records proposer's Vote entry to prevent double-voting - Sets expires_at = ledger().timestamp() + ttl_ledgers * 5 - Emits ProposalCreatedEvent - Returns new proposal ID - Add tests: non-member panic, insufficient funds, ID matches stored proposal, auto-approval, ID increments
Kayce10
force-pushed
the
feature/122-propose-withdraw
branch
from
389374c to
bb44df4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122
Summary
Implements
propose_withdrawonGroupTreasuryContractas specified in issue #122.Changes
storage.rs: AddedWithdrawProposalStatus,WithdrawProposal,ProposalCreatedEventtypes andDataKey::ProposalCount/DataKey::WithdrawProposal(u32)variantslib.rs: Implementedpropose_withdraw(env, proposer, to, token, amount, ttl_ledgers) -> u32amount > 0"insufficient funds")ProposalCount, storesWithdrawProposalwithPendingstatusexpires_at = ledger().sequence() + ttl_ledgersProposalCreatedEventget_withdraw_proposalread helpertest.rs: Added tests covering all acceptance criteriaAcceptance Criteria
"insufficient funds"id