Skip to content

⚡️ Speed up method DefineList.equals by 126% #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method DefineList.equals by 126% #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions jme3-core/src/main/java/com/jme3/shader/DefineList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,12 @@ public boolean equals(Object object) {
if (values.length != otherDefineList.values.length) {
return false;
}
if (!isSet.equals(otherDefineList.isSet)) {
// Compare primitive int array using Arrays.equals which is typically
// optimized by the JVM, and do it before BitSet comparison to fail fast.
if (!Arrays.equals(values, otherDefineList.values)) {
return false;
}
for (int i = 0; i < values.length; i++) {
if (values[i] != otherDefineList.values[i]) {
return false;
}
}
return true;
return isSet.equals(otherDefineList.isSet);
}

public DefineList deepClone() {
Expand Down