Skip to content

fix: update splitAndAssert to allow for more flexible input validation#1

Closed
ATGardner wants to merge 2 commits into
mainfrom
fix-capabilities-request
Closed

fix: update splitAndAssert to allow for more flexible input validation#1
ATGardner wants to merge 2 commits into
mainfrom
fix-capabilities-request

Conversation

@ATGardner

Copy link
Copy Markdown
Collaborator

Adjust the splitAndAssert function to check for at least two elements
in the split result instead of exactly two. This change improves the
function's robustness when handling unexpected input formats.

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

I'm adding a parameter to an existing command X:

  • add parameter to the function in src/api/X.js (and src/commands/X.js if necessary)
  • document the parameter in the JSDoc comment above the function
  • add a test case in __tests__/test-X.js if possible
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README

I'm adding a new command:

  • add as a new file in src/api (and src/commands if necessary)
  • add command to src/index.js
  • update __tests__/test-exports.js
  • create a test in src/__tests__
  • document the command with a JSDoc comment
  • add page to the Docs Sidebar website/sidebars.json
  • add page to the v1 Docs Sidebar website/versioned_sidebars/version-1.x-sidebars.json
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "feat: Added 'X' command"

Adjust the splitAndAssert function to check for at least two elements
in the split result instead of exactly two. This change improves the
function's robustness when handling unexpected input formats.
@ATGardner ATGardner self-assigned this May 27, 2025
@ATGardner ATGardner closed this Jun 10, 2026
@ATGardner ATGardner deleted the fix-capabilities-request branch June 10, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants