Skip to content

Easier to change name of theme#583

Open
highergroundstudio wants to merge 4 commits into
codemonkey-jack:masterfrom
highergroundstudio:master
Open

Easier to change name of theme#583
highergroundstudio wants to merge 4 commits into
codemonkey-jack:masterfrom
highergroundstudio:master

Conversation

@highergroundstudio

Copy link
Copy Markdown

One cannot change the name of the theme from Shoestrap (for custom theme) without changing source
These two commits fix this (other than style.css still could be overwritten).

One cannot change the name of the theme from Shoestrap (for custom theme) without changing source -this partly fixes this
One cannot change the name of the theme from Shoestrap (for custom theme) without changing source -this fixes the other half by changing the option name to be partly the theme name
@aristath

Copy link
Copy Markdown
Collaborator

The only problem I see with this is child themes...

The options should reflect the parent theme's name and not the child.
That's why it's hard-coded at the moment.

If you make it so it's the parent theme's name instead I would have no bjection in merging this. 👍

@aristath

Copy link
Copy Markdown
Collaborator

FYI we've recently started completely rebuilding the theme using the customizer + twig (no redux).

If you're interested in helping out (it still has a looong way to go) the new repo is here: https://github.com/wpmu/shoestrap

Get the parent theme if needed (1/2)
Get the parent theme if needed (2/2)
@highergroundstudio

Copy link
Copy Markdown
Author

Updated this so that it gets the parent if it needs to.

@highergroundstudio

Copy link
Copy Markdown
Author

Are there any plugins needed to run shoestrap 4? I am getting an error about Timber.

@aristath

Copy link
Copy Markdown
Collaborator

Yes, it requires this plugin: http://wordpress.org/plugins/timber-library/
We're working on embedding it in the theme so it won't be necessary to install it as a plugin, but untill we do it's required.

@aristath

Copy link
Copy Markdown
Collaborator

I've been thinking about this...
The changes you made also change the option name in the database: https://github.com/shoestrap/shoestrap-3/pull/583/files#diff-78cd5aa3783a74555c9938a2a81d01c6R27

That would essentially break the theme for anyone that already has it installed, wouldn't it?

@highergroundstudio

Copy link
Copy Markdown
Author

Only if they changed the name. I was thinking more for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants