Repository navigation
feat/test: roman numeral command and CLI tests (#91) - #132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I was the first to claim #91 (comment on the issue) and implemented the feature in #126 (
fixit/roman.py,run_romanincli.py, and 11 tests), opened on Oct 31 before roman support was added tomain. #126 was closed due to merge conflicts aftermaingained its own roman implementation, so this follow-up brings in the test coverage thatmainis still missing.What does this PR do?
tests/test_cli.pyforfixit roman:1994→MCMXCIV)MCMXCIV→1994)4000) returns exit code 1 with the range errorIIII) returns exit code 1 with the "not a valid Roman numeral" error""to the invalid-numeral cases intests/test_roman.pyAs requested in the review on #126:
main, so there are no merge conflictspytest: 62 passedruff checkandruff format --checkpass on the changed filesRelated issue
Related to #91
Checklist
xfailmarker (if fixing a bug) (N/A)pytestpasses locally