fix: guard against malformed/non-array history data in fetchUserInfo#261
Merged
jagdish-15 merged 1 commit intoJun 28, 2026
Merged
Conversation
Contributor
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. Formatting and Branching
|
Contributor
Author
|
Hey @jagdish-15, could you review this pr? |
jagdish-15
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash in
fetch-user-info.jswhen historical user data is malformed. The endpoint now gracefully falls back to an empty history array instead of throwing an error when the fetched JSON isnullor contains a non-arrayhistoryfield.Linked Issue
Fixes #239
Changes Made
Array.isArray(history)guard before sorting historical data.history.sort()from throwing when malformed history data is encountered.Type of Change
Testing
Test Cases
Verified the following scenarios locally:
{})null{ "history": "corrupted" }{ "history": {} }Confirmed that malformed history data now degrades gracefully to an empty history array instead of causing the
/api/user/:usernameendpoint to fail.Checklist
npx prettier --write .before submittingfeature/*branch, not themainbranchScreenshots / Screen Recording
N/A, Backend robustness fix with no UI changes.