fix: wgengine: fix TSMP/ICMP callback leak#122
Merged
Conversation
ethanndickson
approved these changes
May 19, 2026
Member
ethanndickson
left a comment
ethanndickson
left a comment
There was a problem hiding this comment.
identical to the upstream fix, sgtm!
rowansmithau
added a commit
to coder/coder
that referenced
this pull request
May 19, 2026
Updates `github.com/coder/tailscale` to [`v1.1.1-0.20260519043957-6f014ff9434f`](coder/tailscale@6f014ff) to include the fix from [coder/tailscale#122](coder/tailscale#122), which ports the upstream [tailscale/tailscale#18113](tailscale/tailscale#18113) fix for TSMP/ICMP callback leaks. Fixes #25380 > Generated with [Coder Agents](https://coder.com) by @rowansmithau
This was referenced May 19, 2026
rowansmithau
added a commit
to coder/coder
that referenced
this pull request
May 19, 2026
….29) (#25470) Backport of #25469 to `release/2.29`. Updates `github.com/coder/tailscale` to [`v1.1.1-0.20260519043957-6f014ff9434f`](coder/tailscale@6f014ff) to include the fix from [coder/tailscale#122](coder/tailscale#122), which ports the upstream [tailscale/tailscale#18113](tailscale/tailscale#18113) fix for TSMP/ICMP callback leaks. Fixes #25380 > Generated with [Coder Agents](https://coder.com) by @rowansmithau
rowansmithau
added a commit
to coder/coder
that referenced
this pull request
May 19, 2026
….32) (#25473) Backport of #25469 to `release/2.32`. Updates `github.com/coder/tailscale` to [`v1.1.1-0.20260519043957-6f014ff9434f`](coder/tailscale@6f014ff) to include the fix from [coder/tailscale#122](coder/tailscale#122), which ports the upstream [tailscale/tailscale#18113](tailscale/tailscale#18113) fix for TSMP/ICMP callback leaks. Fixes #25380 > Generated with [Coder Agents](https://coder.com) by @rowansmithau
rowansmithau
added a commit
to coder/coder
that referenced
this pull request
May 19, 2026
….31) (#25471) Backport of #25469 to `release/2.31`. Updates `github.com/coder/tailscale` to [`v1.1.1-0.20260519043957-6f014ff9434f`](coder/tailscale@6f014ff) to include the fix from [coder/tailscale#122](coder/tailscale#122), which ports the upstream [tailscale/tailscale#18113](tailscale/tailscale#18113) fix for TSMP/ICMP callback leaks. Fixes #25380 > Generated with [Coder Agents](https://coder.com) by @rowansmithau
rowansmithau
added a commit
to coder/coder
that referenced
this pull request
May 19, 2026
….33) (#25472) Backport of #25469 to `release/2.33`. Updates `github.com/coder/tailscale` to [`v1.1.1-0.20260519043957-6f014ff9434f`](coder/tailscale@6f014ff) to include the fix from [coder/tailscale#122](coder/tailscale#122), which ports the upstream [tailscale/tailscale#18113](tailscale/tailscale#18113) fix for TSMP/ICMP callback leaks. Fixes #25380 > Generated with [Coder Agents](https://coder.com) by @rowansmithau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is an attempted fix for the issue detailed in coder/coder#25380.
it adds the changes in the upstream PR at tailscale#18113 as well as some tests which were created specifically to highlight the before/after changes (and as a result don't necessarily need to be merged)