Revert "feat: add coder_secret data source for user secrets (#501)"#512
Open
zedkipp wants to merge 1 commit into
Open
Revert "feat: add coder_secret data source for user secrets (#501)"#512zedkipp wants to merge 1 commit into
zedkipp wants to merge 1 commit into
Conversation
This reverts commit af77cd5. Removes the coder_secret data source AND the SecretEnvEnvironmentVariable / SecretFileEnvironmentVariable helpers that coderd consumed. Requires the matching changes in coder/coder and coder/preview that remove the secret-injection plumbing entirely. Co-authored-by: Coder Agents <agents@coder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit af77cd5.
Removes the coder_secret data source AND the
SecretEnvEnvironmentVariable/SecretFileEnvironmentVariablehelpers that coderd consumed.Requires the matching changes in coder/coder and coder/preview that remove the secret-injection plumbing entirely.
This is being reverted because we are pivoting on the direction of the secrets feature.