refactor: move memento-backed state out of SecretsManager#1029
Merged
Conversation
Deployment access timestamps, surfaced banner keys, and the legacy url key now live in MementoManager, keeping SecretsManager secrets-only. SecretsManager takes a MementoManager and still orchestrates per-deployment cleanup so both stores stay in sync, and AnnouncementManager depends on MementoManager directly. The surfaced banner read-modify-write moved into MementoManager.addSurfacedBanners. Keys and formats are unchanged, so no data migration. Closes #1023
EhabY
force-pushed
the
split-memento-out-of-secrets-manager
branch
from
4cbe4b4 to
e7f0e8d
Compare
mtojek
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1023
SecretsManagerhad grown to also persist non-secret state in the workspaceMemento: deployment access timestamps (coder.access.*), surfaced announcement banners (coder.surfacedBanners.*), and the legacyurlkey. This moves all of it intoMementoManager, keepingSecretsManagersecrets-only.SecretsManagernow takes aMementoManagerinstead of a rawMemento. Secret writes still stamp deployment access,getKnownSafeHostnamesstill orders by it, andclearAllAuthDataremains the single per-deployment cleanup entry point, delegating the memento clears so both stores stay in sync.AnnouncementManagerdepends onMementoManagerdirectly. The surfaced-banner read-modify-write moved intoMementoManager.addSurfacedBanners, so any future atomic memento update can be adopted in one place.Follow up to #1018